Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Also use pageshow event for URL change cue #228

Merged
merged 1 commit into from
Nov 11, 2015

Conversation

lmorchard
Copy link
Contributor

Closes #124

@lmorchard
Copy link
Contributor Author

I'm not entirely sure if this is the right fix, since I'm still wrapping my head around the events and issues with them. But, this seems to fix the issue. Might be worth an upstream ampersand patch if it's the right thing to do

lmorchard added a commit that referenced this pull request Nov 11, 2015
Also use pageshow event for URL change cue
@lmorchard lmorchard merged commit b1a7dce into mozilla:master Nov 11, 2015
@jaredhirsch
Copy link
Member

Per all the crazy links I dropped in IRC earlier, adding a no-op unload listener should resolve any bfcache issues in FF. I kinda think this fix is cleaner, though

@lmorchard lmorchard deleted the 124-back-button-broken branch August 9, 2016 17:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants